[XS] Change in openvpn[master]: Silence warning with gcc 15 and O0/01

"plaisthos \(Code Review\) via Openvpn-devel" <[email protected]>
Newsgroups gmane.network.openvpn.devel
Message-ID <[email protected]>
plaisthos has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/1731?usp=email )


Change subject: Silence warning with gcc 15 and O0/01
......................................................................

Silence warning with gcc 15 and O0/01

When compiling with low optimisation level gcc complains

   route.c:1783:44: error: conversion from ‘int’ to ‘uint8_t’ {aka ‘unsigned char’} may change value [-Werror=conversion]
    1783 |             r6->network.s6_addr[byte--] &= (0xff << bits_to_clear);

With higher it apparently detects that this is cannot be and does not
trigger the warning. Explicitly cast to uint8_t to silence this warning

Change-Id: I96d3698601bb5aac3a0d7ac6ac5b5dd23c975517
Signed-off-by: Arne Schwabe <[email protected]>
---
M src/openvpn/route.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/31/1731/1

diff --git a/src/openvpn/route.c b/src/openvpn/route.c
index 81ce867..8ea745d 100644
--- a/src/openvpn/route.c
+++ b/src/openvpn/route.c
@@ -1780,7 +1780,7 @@
         }
         else
         {
-            r6->network.s6_addr[byte--] &= (0xff << bits_to_clear);
+            r6->network.s6_addr[byte--] &= (uint8_t)(0xff << bits_to_clear);
             bits_to_clear = 0;
         }
     }

-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1731?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I96d3698601bb5aac3a0d7ac6ac5b5dd23c975517
Gerrit-Change-Number: 1731
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.