[M] Change in openvpn[master]: win32: fix plugin trusted-dir check prefix bypass

Attention is currently required from: stipa.

plaisthos has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1736?usp=email )

Change subject: win32: fix plugin trusted-dir check prefix bypass
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File src/openvpn/win32-util.c:

http://gerrit.openvpn.net/c/openvpn/+/1736/comment/d02afeba_81f8d36e?usp=email :
PS1, Line 182:     if (dir_len == 0 || wcsnicmp(dir, path, dir_len) != 0)
I think since you are doing dir_len -1 below you should maybe change the dir_len check to be <= 1



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1736?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib7f9c9ce5ed778190445cc4cfaa8f3cd5d1110bc
Gerrit-Change-Number: 1736
Gerrit-PatchSet: 1
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: stipa <[email protected]>
Gerrit-Comment-Date: Sat, 27 Jun 2026 10:36:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel