[M] Change in openvpn[master]: multipeer: introduce asymmetric peer-id

Attention is currently required from: flichtenheld, plaisthos.

its_Giaan has posted comments on this change by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/1089?usp=email )

Change subject: multipeer: introduce asymmetric peer-id
......................................................................


Patch Set 16:

(4 comments)

File src/openvpn/multi.c:

http://gerrit.openvpn.net/c/openvpn/+/1089/comment/8d816606_628dd24e?usp=email :
PS16, Line 1729: 
> spurious change
Done


File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/1089/comment/58dea1af_17b21c2d?usp=email :
PS16, Line 3890: 
> spurious change
Done


File src/openvpn/ssl.c:

http://gerrit.openvpn.net/c/openvpn/+/1089/comment/b9c300b5_e281c165?usp=email :
PS16, Line 2347:         free(multi->peer_info);
> useless free, we know it is NULL
Done


http://gerrit.openvpn.net/c/openvpn/+/1089/comment/1b54d5fd_1af13e14?usp=email :
PS16, Line 2348:         multi->peer_info = read_string_alloc(buf);
> This needs a comment. […]
If I remember correctly we needed this because the server were supposed to send an empty string via peer_info (as you can see from the previous code, when peer_info_details are < 1 we just print an empty string to the buffer) but, we the latest changes we made this else block is no more required so I reworked this part a bit.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1089?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0a13ee90b6706acf20eabcee3bab3f2dff639bf9
Gerrit-Change-Number: 1089
Gerrit-PatchSet: 16
Gerrit-Owner: its_Giaan <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Mon, 29 Jun 2026 01:39:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel