[XS] Change in openvpn[master]: dco.c: fix argument order in dco_install_key() log string

cron2 has uploaded a new patch set (#2) to the change originally created by ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/1760?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by cron2


Change subject: dco.c: fix argument order in dco_install_key() log string
......................................................................

dco.c: fix argument order in dco_install_key() log string

The debug log in dco_install_key() has the epoch and dco_keys_installed
arguments swapped. So a line like epoch=1, currently 0 keys installed
actually means dco_keys_installed == 1 and epoch == false.

Use the correct argument ordering in the log string.

Change-Id: Id8945dce437da11e6fecae9550c3be52e393d4cf
Signed-off-by: Ralf Lici <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1760
Message-Id: <[email protected]>
URL: https://www.mail-archive.com/[email protected]/msg37418.html
Signed-off-by: Gert Doering <[email protected]>
---
M src/openvpn/dco.c
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/60/1760/2

diff --git a/src/openvpn/dco.c b/src/openvpn/dco.c
index f5b7081..e944547 100644
--- a/src/openvpn/dco.c
+++ b/src/openvpn/dco.c
@@ -57,8 +57,8 @@
 
 {
     bool epoch = ks->crypto_options.flags & CO_EPOCH_DATA_KEY_FORMAT;
-    msg(D_DCO_DEBUG, "%s: peer_id=%d keyid=%d epoch=%d, currently %d keys installed", __func__,
-        multi->dco_peer_id, ks->key_id, multi->dco_keys_installed, epoch);
+    msg(D_DCO_DEBUG, "%s: peer_id=%d keyid=%d epoch=%d, currently %d keys installed",
+        __func__, multi->dco_peer_id, ks->key_id, epoch, multi->dco_keys_installed);
 
     /* Install a key in the PRIMARY slot only when no other key exist.
      * From that moment on, any new key will be installed in the SECONDARY

-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1760?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id8945dce437da11e6fecae9550c3be52e393d4cf
Gerrit-Change-Number: 1760
Gerrit-PatchSet: 2
Gerrit-Owner: ralf_lici <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel