[S] Change in openvpn[master]: init: create and destroy Linux DCO devices with --mktun/--rmtun
"ralf_lici \(Code Review\) via Openvpn-devel" <[email protected]>
| Newsgroups | gmane.network.openvpn.devel |
|---|---|
| Message-ID | <db9d78190285964d9eccff31a44ada47e18e6060-EmailReviewComments-HTML@gerrit.openvpn.net> |
Attention is currently required from: plaisthos. ralf_lici has posted comments on this change by ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/1735?usp=email ) Change subject: init: create and destroy Linux DCO devices with --mktun/--rmtun ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > you could make the argument to mktun optional. […] I see a few potential issues with this approach: `--mktun dco-p2p --mode server`, `--mktun dco-server --mode p2p`, `--mktun dco-* --disable-dco`, `--mktun tun --dev tap` (which would be the only way to create a TAP device, but it’s not very intuitive). All of these cases can be handled, but they would add extra edge‑case logic in `options.c`, and the resulting behavior might not be very clear to users. The main question is whether we accept that, in 2.8, `--mktun` will default to DCO when available. If yes, then adding new options or arguments doesn’t seem necessary, since the existing flags already cover the needed combinations. If not, I’d avoid encoding `--mode` inside `--mktun`. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1735?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic8c83132a4de64f27e6453ddb90ebcf137500db2 Gerrit-Change-Number: 1735 Gerrit-PatchSet: 1 Gerrit-Owner: ralf_lici <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Wed, 01 Jul 2026 15:56:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: plaisthos <[email protected]> Comment-In-Reply-To: ralf_lici <[email protected]> _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel