[S] Change in openvpn[master]: mingw: avoid C99 "hh" scanf length modifier

Attention is currently required from: d12fk, plaisthos.

flichtenheld has posted comments on this change by d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/1733?usp=email )

Change subject: mingw: avoid C99 "hh" scanf length modifier
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

File src/openvpn/crypto.c:

http://gerrit.openvpn.net/c/openvpn/+/1733/comment/7e2808a9_614d1954?usp=email :
PS2, Line 1477:                         ASSERT(sscanf((const char *)hex_byte, "%" SCNx8, &u) == 1);
> Certainly true for MinGW on 26.04. There is a uLibc, that supports %hhx. […]
After researching this myself a bit I agree with both the sentiment that this is a mess and with Heiko's assessment that a work-around is currently the easiest solution.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1733?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6595695ab6401047d498d530f8739686880bea3a
Gerrit-Change-Number: 1733
Gerrit-PatchSet: 2
Gerrit-Owner: d12fk <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: d12fk <[email protected]>
Gerrit-Comment-Date: Fri, 03 Jul 2026 11:53:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos <[email protected]>
Comment-In-Reply-To: d12fk <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel