[M] Change in openvpn[master]: Extract multi_check_dest_addr_allowed from multi_process_float

"flichtenheld \(Code Review\) via Openvpn-devel" <[email protected]>
Newsgroups gmane.network.openvpn.devel
Message-ID <d617adaf36dcaf0fa62d9f2407d0b10970bf664a-EmailReviewComments-HTML@gerrit.openvpn.net>
Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1723?usp=email )

Change subject: Extract multi_check_dest_addr_allowed from multi_process_float
......................................................................


Patch Set 3: Code-Review-1

(4 comments)

Patchset:

PS3: 
Code looks good, but comment could use some fixes


File src/openvpn/multi.c:

http://gerrit.openvpn.net/c/openvpn/+/1723/comment/a7ac98b9_1e5c38cf?usp=email :
PS3, Line 3078:  * Reasons for disallowing a specific adress are that a client might be
"address"


http://gerrit.openvpn.net/c/openvpn/+/1723/comment/46679090_5e10169b?usp=email :
PS3, Line 3079:  * already using that address. In that case the method need to decide
"needs"


http://gerrit.openvpn.net/c/openvpn/+/1723/comment/9754a51e_35cbd68e?usp=email :
PS3, Line 3080:  * if the this instance can kick out the other instance.
"the this" -> "this"



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1723?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3d52c6d008502293c3ec57ad22d1c613dcd1a94e
Gerrit-Change-Number: 1723
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Mon, 06 Jul 2026 12:18:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.