[L] Change in openvpn[master]: oob: Add control message TLV encoding (P_CONTROL_OOB_V1)

Attention is currently required from: plaisthos, stipa.

flichtenheld has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1741?usp=email )

Change subject: oob: Add control message TLV encoding (P_CONTROL_OOB_V1)
......................................................................


Patch Set 3: Code-Review-1

(5 comments)

File src/openvpn/oob.h:

http://gerrit.openvpn.net/c/openvpn/+/1741/comment/42e94415_5c8f2b50?usp=email :
PS3, Line 35:  * This slice implements the SERVER_PROBE / PROBE_REPLY pair used for server
Not sure of the purpose of this sentence?


http://gerrit.openvpn.net/c/openvpn/+/1741/comment/0d55380a_a563bb77?usp=email :
PS3, Line 62: #define OOB_PROBE_PARAMETER_LEN 12
why do we hardcode those instead of defining them via sizeof() ?


File src/openvpn/oob.c:

http://gerrit.openvpn.net/c/openvpn/+/1741/comment/7bda6ca1_5d7760a6?usp=email :
PS3, Line 31: /* Consume @p value_len bytes of TLV value, of which @p consumed have already
Doxygen syntax but not marked as Doxygen comment


http://gerrit.openvpn.net/c/openvpn/+/1741/comment/5d122562_14850b3c?usp=email :
PS3, Line 105:     if (!ok)
Is that safe? If the buffer has enough to read for u32 but not for u64 could we end up with ok being true?


File tests/unit_tests/openvpn/test_oob.c:

http://gerrit.openvpn.net/c/openvpn/+/1741/comment/72e0985a_82f563a3?usp=email :
PS3, Line 153: /* Reading a header from a buffer that is too small must fail rather than read
This comment does not seem to correspond to the test. The buffer is big enough. This tests for malformed TLV headers, doesn't it?



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1741?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1c8d302ac57c5603d622a7be14be369437388268
Gerrit-Change-Number: 1741
Gerrit-PatchSet: 3
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: stipa <[email protected]>
Gerrit-Comment-Date: Wed, 08 Jul 2026 16:13:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel