[S] Change in openvpn[master]: buffer: Add buf_read_u64() and buf_write_u64()

Attention is currently required from: plaisthos, stipa.

cron2 has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1740?usp=email )

Change subject: buffer: Add buf_read_u64() and buf_write_u64()
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Patchset:

PS2: 
The code is probably good, but the commit message does not make sense - it talks about "no portable 64 bit byte-order primitive" and then the code just uses `htonll()`.  No what? ;-)



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1740?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic677f43fc3eb0052f8e80d9a7f098d34ad03dfe1
Gerrit-Change-Number: 1740
Gerrit-PatchSet: 2
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: stipa <[email protected]>
Gerrit-Comment-Date: Wed, 08 Jul 2026 20:01:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel