[XS] Change in openvpn[master]: win32-util.h: Fix includes

"flichtenheld \(Code Review\) via Openvpn-devel" <[email protected]>
Newsgroups gmane.network.openvpn.devel
Message-ID <[email protected]>
Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1779?usp=email

to review the following change.


Change subject: win32-util.h: Fix includes
......................................................................

win32-util.h: Fix includes

This file includes various headers but then doesn't
use anything from them. It does not include the header
(buffer.h) it actually uses.

Change-Id: Ie44556f5ece28b54cc657fa86261b827efb42467
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpn/win32-util.h
1 file changed, 1 insertion(+), 5 deletions(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/79/1779/1

diff --git a/src/openvpn/win32-util.h b/src/openvpn/win32-util.h
index 4849ea9..fb83762 100644
--- a/src/openvpn/win32-util.h
+++ b/src/openvpn/win32-util.h
@@ -24,11 +24,7 @@
 #ifndef OPENVPN_WIN32_UTIL_H
 #define OPENVPN_WIN32_UTIL_H
 
-#include <winioctl.h>
-
-#include "mtu.h"
-#include "openvpn-msg.h"
-#include "argv.h"
+#include "buffer.h"
 
 /* Convert a string from UTF-8 to UCS-2 */
 WCHAR *wide_string(const char *utf8, struct gc_arena *gc);

-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1779?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie44556f5ece28b54cc657fa86261b827efb42467
Gerrit-Change-Number: 1779
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.