[M] Change in openvpn[master]: Split multi_get_create_instance_udp into data and control parts

Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1726?usp=email )

Change subject: Split multi_get_create_instance_udp into data and control parts
......................................................................


Patch Set 4: Code-Review-2

(1 comment)

File src/openvpn/mudp.c:

http://gerrit.openvpn.net/c/openvpn/+/1726/comment/4600a392_e77fc5ec?usp=email :
PS4, Line 364:     if (!mroute_extract_openvpn_sockaddr(&real, &m->top.c2.from.dest, true) || m->top.c2.buf.len == 0)
This check is too late now and it is wrong. In t_server testbed we see segfaults:

```
Program terminated with signal SIGSEGV, Segmentation fault.
#0  multi_get_create_instance_udp (m=0x7fff74cfe0a0, 
    floated=floated@entry=0x7fff74cfdfcf, sock=sock@entry=0x2525b90) at mudp.c:359

warning: Source file is more recent than executable.
359	    uint8_t op = ptr[0] >> P_OPCODE_SHIFT;
(gdb) print m->top.c2.buf
$2 = {capacity = 2466, offset = 136, len = -1, data = 0x2563f40 ""}

```



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1726?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I8e9923b51b77f184c7d49d697004cb02d2b5cfc3
Gerrit-Change-Number: 1726
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Wed, 15 Jul 2026 10:08:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel