[S] Change in openvpn[master]: Only announce support push updates/IV_NCP when actually supporting it

Attention is currently required from: plaisthos.

cron2 has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1634?usp=email )

Change subject: Only announce support push updates/IV_NCP when actually supporting it
......................................................................


Patch Set 7: Code-Review-2

(1 comment)

File src/openvpn/ssl.c:

http://gerrit.openvpn.net/c/openvpn/+/1634/comment/60cdb326_0f4bce27?usp=email :
PS7, Line 1997:         {
NAK on that change, because it would lead to a setup with `--server` + `--push-peer-info` send out IV_PROTO_NCP_P2P... so the `MODE_SERVER` check is needed.  Unlikely scenario, but possible...



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1634?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0737b769e78e6d271ec874cadb9fbd81bfefdec1
Gerrit-Change-Number: 1634
Gerrit-PatchSet: 7
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Wed, 15 Jul 2026 14:57:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel