Re: [PATCH applied] Re: test_tls_crypt: Fix test failure on Windows

Gert Doering <[email protected]> Fri, 17 Jul 2026 15:54:15 +0200

Newsgroups	gmane.network.openvpn.devel
Message-ID	<[email protected]>

Hi,

On Tue, Jul 14, 2026 at 04:31:27PM +0200, Gert Doering wrote:
> Failing tests "on some platforms" are most annoying, because you keep
> ignoring *real* fails then, after a while... so thanks for fixing this.
> 
> Gerrit says "all green" which is all I want here ;-)
> 
> Your patch has been applied to the master and release/2.7 branch
> ("fix test infra").
> 
> commit a3942a62ff3c8e8f0a5dc577e24552a4d4fa5fb0 (master)
> commit d8bbfbc56c5f15080d781f7307aebb2d809d36e8 (release/2.7)
> Author: Frank Lichtenheld
> Date:   Tue Jul 14 14:12:29 2026 +0200

As it turns out, release/2.6 GHA builds also fail because of this
(the original problem patch was part of the large "CVEs everywhere"
series that was also merged to release/2.6) - so I have backported
this to 2.6 as well

commit dbffaae19600d537ddc616c507ee0df72ae2b5a3 (release/2.6)

the change is straightforward, just "git cherry-pick" was getting confused
by "older code base" and flagged many conflicts that really were none.


Tested via GHA, which builds and runs this on macOS, Linux, and Windows
(well, #ifndef _WIN32, so it does not technically "run *this* test on
Windows", but the rest of the test_tls_crypt unit test is back to "green").

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             [email protected]

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

signature.asc (application/pgp-signature, 699 B)