[L] Change in openvpn[master]: Add lookup of multi session by session id

Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1727?usp=email )

Change subject: Add lookup of multi session by session id
......................................................................


Patch Set 5: Code-Review-2

(2 comments)

File src/openvpn/sid_hash.h:

http://gerrit.openvpn.net/c/openvpn/+/1727/comment/5f1dda6a_a224f258?usp=email :
PS5, Line 59:     struct hash_element *he = multi_hash_sid_lookup(m, sid);
```
sid_hash.h:59:56: error: passing argument 2 of ‘multi_hash_sid_lookup’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
   59 |     struct hash_element *he = multi_hash_sid_lookup(m, sid);
      |                                                        ^~~
sid_hash.h:48:67: note: expected ‘struct session_id *’ but argument is of type ‘const struct session_id *’
   48 | multi_hash_sid_lookup(struct multi_context *m, struct session_id *sid)
```


http://gerrit.openvpn.net/c/openvpn/+/1727/comment/73b795c6_c478883e?usp=email :
PS5, Line 64:         ASSERT(hash_remove_fast(m->sid_hash, bucket, sid, hv));
```
sid_hash.h:64:46: error: ‘bucket’ undeclared (first use in this function); did you mean ‘socket’?
   64 |         ASSERT(hash_remove_fast(m->sid_hash, bucket, sid, hv));
sid_hash.h:64:59: error: ‘hv’ undeclared (first use in this function); did you mean ‘he’?
   64 |         ASSERT(hash_remove_fast(m->sid_hash, bucket, sid, hv));
```



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1727?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Idb59ecd119331b198792ad1379bec8600211651b
Gerrit-Change-Number: 1727
Gerrit-PatchSet: 5
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Fri, 17 Jul 2026 15:25:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel