[L] Change in openvpn[master]: oob: Add control message TLV encoding (P_CONTROL_OOB_V1)

Attention is currently required from: plaisthos, stipa.

flichtenheld has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1741?usp=email )

Change subject: oob: Add control message TLV encoding (P_CONTROL_OOB_V1)
......................................................................


Patch Set 7:

(4 comments)

File src/openvpn/oob.h:

http://gerrit.openvpn.net/c/openvpn/+/1741/comment/8e8394ef_e1488568?usp=email :
PS3, Line 35:  * This slice implements the SERVER_PROBE / PROBE_REPLY pair used for server
> This is about series of patches. I agree it might add confusion so I'll remote it.
Acknowledged


File src/openvpn/oob.c:

http://gerrit.openvpn.net/c/openvpn/+/1741/comment/65179444_a7cb9a36?usp=email :
PS3, Line 31: /* Consume @p value_len bytes of TLV value, of which @p consumed have already
> Will change to real doxygen.
Done


http://gerrit.openvpn.net/c/openvpn/+/1741/comment/456532e6_83b27529?usp=email :
PS3, Line 105:     if (!ok)
> No, this is a bug. Will fix.
Done


File tests/unit_tests/openvpn/test_oob.c:

http://gerrit.openvpn.net/c/openvpn/+/1741/comment/5f264f3c_60e1f85c?usp=email :
PS3, Line 153: /* Reading a header from a buffer that is too small must fail rather than read
> Will rephrase, thanks!
Done



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1741?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1c8d302ac57c5603d622a7be14be369437388268
Gerrit-Change-Number: 1741
Gerrit-PatchSet: 7
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: stipa <[email protected]>
Gerrit-Comment-Date: Mon, 20 Jul 2026 13:23:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]>
Comment-In-Reply-To: stipa <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel