[M] Change in openvpn[master]: Enable TCP_NODELAY by default and deprecate --tcp-nodelay

Attention is currently required from: ordex.

plaisthos has posted comments on this change by ordex. ( http://gerrit.openvpn.net/c/openvpn/+/1797?usp=email )

Change subject: Enable TCP_NODELAY by default and deprecate --tcp-nodelay
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

Patchset:

PS1: 
I think it is a good idea but I think we can clean up a bit more.


File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/1797/comment/089b99ab_9a547c6b?usp=email :
PS1, Line 7710:         msg(M_WARN, "DEPRECATED OPTION: --tcp-nodelay is now the default and "
is enabled by default.


File src/openvpn/socket.c:

http://gerrit.openvpn.net/c/openvpn/+/1797/comment/f74cde81_10fbe178?usp=email :
PS1, Line 1492:         sock->sockflags |= SF_TCP_NODELAY;
Let's get rid of SF_TCP_NODELAY. And maybe the whole socket_set_flags wrapper and just do:

if (proto_is_tcp(sock->info.proto) && !sock->sockflags & SF_DCO_WIN)
   socket_set_tcp_nodelay(sd, 1)
   
to clean up the code.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1797?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I434a5373f77b0f7570a6a2aafe0eaf970e2eabe7
Gerrit-Change-Number: 1797
Gerrit-PatchSet: 1
Gerrit-Owner: ordex <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: ordex <[email protected]>
Gerrit-Comment-Date: Mon, 20 Jul 2026 23:18:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel