[M] Change in openvpn[master]: Enable TCP_NODELAY by default and deprecate --tcp-nodelay
"ordex \(Code Review\) via Openvpn-devel" <[email protected]>
| Newsgroups | gmane.network.openvpn.devel |
|---|---|
| Message-ID | <2d6f1da9cb61c91c19dfea844177e0c4c7557a57-EmailReviewComments-HTML@gerrit.openvpn.net> |
ordex has posted comments on this change by ordex. ( http://gerrit.openvpn.net/c/openvpn/+/1797?usp=email ) Change subject: Enable TCP_NODELAY by default and deprecate --tcp-nodelay ...................................................................... Patch Set 2: (2 comments) File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/1797/comment/e47c1e5d_41a48ba6?usp=email : PS1, Line 7710: msg(M_WARN, "DEPRECATED OPTION: --tcp-nodelay is now the default and " > is enabled by default. Done File src/openvpn/socket.c: http://gerrit.openvpn.net/c/openvpn/+/1797/comment/46b8588e_c78f6602?usp=email : PS1, Line 1492: sock->sockflags |= SF_TCP_NODELAY; > Let's get rid of SF_TCP_NODELAY. And maybe the whole socket_set_flags wrapper and just do: […] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1797?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I434a5373f77b0f7570a6a2aafe0eaf970e2eabe7 Gerrit-Change-Number: 1797 Gerrit-PatchSet: 2 Gerrit-Owner: ordex <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Comment-Date: Tue, 21 Jul 2026 07:33:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: plaisthos <[email protected]> _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel