[M] Change in openvpn[master]: Enable TCP_NODELAY by default and deprecate --tcp-nodelay

Attention is currently required from: ordex.

cron2 has posted comments on this change by ordex. ( http://gerrit.openvpn.net/c/openvpn/+/1797?usp=email )

Change subject: Enable TCP_NODELAY by default and deprecate --tcp-nodelay
......................................................................


Patch Set 2: Code-Review-2

(1 comment)

Patchset:

PS2: 
The documentation reads as if this is intended for 2.7, but the way it is coded (removing the `push` bits) will turn TCP_NODELAY *off* on clients where this is today pushed from the server (server config with `tcp-nodelay` -> `helper_tcp_nodelay()` -> `push socket-flags TCP_NODELAY`).

So for a 2.7 patch, "turn it on" is likely acceptable, but "turn off the pushing functionality" it is not.  For a master patch, it's still arguable if that is a good idea.

That said, the documentation also spends quite a few (new!) words on explaining what `TCP_NODELAY` does - which is a bit weird to add this if it's no longer configurable.  So this needs more work overall.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1797?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I434a5373f77b0f7570a6a2aafe0eaf970e2eabe7
Gerrit-Change-Number: 1797
Gerrit-PatchSet: 2
Gerrit-Owner: ordex <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: ordex <[email protected]>
Gerrit-Comment-Date: Tue, 21 Jul 2026 09:20:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel