[L] Change in openvpn[master]: multipeer: introduce asymmetric peer-id

Attention is currently required from: cron2, flichtenheld, its_Giaan, plaisthos.

ordex has posted comments on this change by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/1089?usp=email )

Change subject: multipeer: introduce asymmetric peer-id
......................................................................


Patch Set 19:

(2 comments)

File src/openvpn/ssl.c:

http://gerrit.openvpn.net/c/openvpn/+/1089/comment/ff85c098_36cb0bb2?usp=email :
PS19, Line 1200:             multi->rx_peer_id = ((uint32_t)peerid[0] << 16)
what happens if this turns to be MAX_PEER_ID (0xFFFFFF)? Could this be problematic?


File src/openvpn/ssl_util.c:

http://gerrit.openvpn.net/c/openvpn/+/1089/comment/9284a278_d1666f37?usp=email :
PS19, Line 78:     const char *optstr = peer_info ? strstr(peer_info, "ID=") : NULL;
could the strstr() also match substrings like "UV_ID=..." or "GUID=..."?



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1089?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0a13ee90b6706acf20eabcee3bab3f2dff639bf9
Gerrit-Change-Number: 1089
Gerrit-PatchSet: 19
Gerrit-Owner: its_Giaan <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: ordex <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: its_Giaan <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Tue, 21 Jul 2026 22:55:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel