[L] Change in openvpn[master]: Allow to use OpenSSL's SIPHASH implementation when available

Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/31?usp=email )

Change subject: Allow to use OpenSSL's SIPHASH implementation when available
......................................................................


Patch Set 17:

(4 comments)

File src/openvpn/siphash.h:

http://gerrit.openvpn.net/c/openvpn/+/31/comment/688ba2b3_578a30d1?usp=email :
PS17, Line 74:     if (siphash_cryptolib_available(ctx) && false)
> && false
Acknowledged


File src/openvpn/siphash_openssl.c:

http://gerrit.openvpn.net/c/openvpn/+/31/comment/0d436523_940cec29?usp=email :
PS17, Line 27: #include "config-msvc.h"
> This shows how old this patch is: config-msvc is gone for years, please remove the reference.
Done


http://gerrit.openvpn.net/c/openvpn/+/31/comment/c5d23503_7391547a?usp=email :
PS17, Line 32: #include "siphash.h"
> these includes could move below the enable check
I trimmed the includes to just siphash.h and added crypto_backend.h in the OpenSSL path.


File tests/unit_tests/openvpn/test_crypto.c:

http://gerrit.openvpn.net/c/openvpn/+/31/comment/d94e0796_6dd8a399?usp=email :
PS17, Line 960:         cmocka_unit_test_prestate_setup_teardown(crypto_test_epoch_edge,
> Removes this test. […]
Acknowledged



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/31?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I09aa27caa1a3aab0d1be6118b26d54a1c1bf7aa0
Gerrit-Change-Number: 31
Gerrit-PatchSet: 17
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Wed, 22 Jul 2026 10:24:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel