[M] Change in openvpn[master]: Make --x509-username-field work with Mbed TLS

Attention is currently required from: MaxF, plaisthos.

flichtenheld has posted comments on this change by MaxF. ( http://gerrit.openvpn.net/c/openvpn/+/1801?usp=email )

Change subject: Make --x509-username-field work with Mbed TLS
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

File src/openvpn/ssl_verify_mbedtls.c:

http://gerrit.openvpn.net/c/openvpn/+/1801/comment/eefeceba_1fd4e696?usp=email :
PS2, Line 245:             if (cn_index >= cn_len)
Strictly speaking we can abort here if `>= cn_len -1` since we always write 2 characters


File tests/unit_tests/openvpn/test_ssl.c:

http://gerrit.openvpn.net/c/openvpn/+/1801/comment/320a3e9c_7e456dd6?usp=email :
PS2, Line 844:     ret = backend_x509_get_username(username, sizeof(username), "serialNumber", cert);
Probably should add an additional test to exercise the length checks?



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1801?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic183f1f1f90561454b7b1128c95255368427cc4a
Gerrit-Change-Number: 1801
Gerrit-PatchSet: 2
Gerrit-Owner: MaxF <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: MaxF <[email protected]>
Gerrit-Comment-Date: Wed, 22 Jul 2026 13:29:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel