[M] Change in openvpn[master]: Allow extracing other integers from peer info and add a unit test for it

Attention is currently required from: cron2.

plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1800?usp=email )

Change subject: Allow extracing other integers from peer info and add a unit test for it
......................................................................


Patch Set 4:

(2 comments)

File src/openvpn/ssl_util.c:

http://gerrit.openvpn.net/c/openvpn/+/1800/comment/31f4551d_4a808ee6?usp=email :
PS3, Line 97:         if (r == 1 && proto > 0)
> this looks like a highly complicated way to do  […]
Done


http://gerrit.openvpn.net/c/openvpn/+/1800/comment/96cf7976_194c65b5?usp=email :
PS3, Line 116:     }
> why not use `peer_info_extract_uint()` with `MAX_PEER_ID` as "default if unset" value?  done, reduce […]
because it needs %x instead of %d to parse. I added peer_info_extract_int to still be able to unify the code paths.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1800?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iad94e7a9d0b3be8a8db09e9a20eaac6041470ab6
Gerrit-Change-Number: 1800
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Comment-Date: Wed, 22 Jul 2026 17:16:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel