[M] Change in openvpn[master]: Do not differentiate TLS server and client context initialisation

Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1728?usp=email )

Change subject: Do not differentiate TLS server and client context initialisation
......................................................................


Patch Set 4: Code-Review+2

(5 comments)

Patchset:

PS4: 
Code looks good, commit message could use some work


Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/1728/comment/49dcfa3f_f4ff953b?usp=email :
PS4, Line 26: Our mbed TLS code basically does give the SSL context any personality
"doesn't" ?


http://gerrit.openvpn.net/c/openvpn/+/1728/comment/35799328_5aaabb29?usp=email :
PS4, Line 28: code calls SSL_set_accept_state/SSL_set_connect_sate.
"SSL_set_connect_state"


http://gerrit.openvpn.net/c/openvpn/+/1728/comment/44f47685_ddabdc9f?usp=email :
PS4, Line 30: This also modifies the mbedTLS to use the decision to pick client
"the mbedTLS backend" maybe?


http://gerrit.openvpn.net/c/openvpn/+/1728/comment/2268e2bc_41f41786?usp=email :
PS4, Line 31: and server in that path as the OpenSSL code path.
"in that path as the OpenSSL code path" -> "in key_state_ssl_init, same as OpenSSL"



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1728?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iaf1f3475e4f27a920c028cd73b1a2497953583d0
Gerrit-Change-Number: 1728
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Thu, 23 Jul 2026 12:14:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel