[L] Change in openvpn[master]: Allow to use OpenSSL's SIPHASH implementation when available

"plaisthos \(Code Review\) via Openvpn-devel" <[email protected]> Fri, 24 Jul 2026 11:01:45 +0000
Newsgroups gmane.network.openvpn.devel
Message-ID <0eba8f41382bb42229165cf100b312bbc82f7f2d-EmailReviewComments-HTML@gerrit.openvpn.net>
Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/31?usp=email )

Change subject: Allow to use OpenSSL's SIPHASH implementation when available
......................................................................


Patch Set 20:

(2 comments)

File src/openvpn/siphash_openssl.c:

http://gerrit.openvpn.net/c/openvpn/+/31/comment/757021fb_e8295323?usp=email :
PS20, Line 82:     ALLOC_OBJ(sip, struct siphash_context);
> Strictly speaking this requires buffer. […]
Done


File tests/unit_tests/openvpn/test_crypto.c:

http://gerrit.openvpn.net/c/openvpn/+/31/comment/436475ab_bd3ca198?usp=email :
PS20, Line 935:     const char *message = "Look behind you, a Three-Headed Monkey!";
> All this test data is duplicated, could be shared between the two tests
Done



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/31?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I09aa27caa1a3aab0d1be6118b26d54a1c1bf7aa0
Gerrit-Change-Number: 31
Gerrit-PatchSet: 20
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Fri, 24 Jul 2026 11:01:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel