[L] Change in openvpn[master]: Replace custom hash_func with siphash

Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1573?usp=email )

Change subject: Replace custom hash_func with siphash
......................................................................


Patch Set 11: Code-Review-1

(3 comments)

File src/openvpn/siphash.h:

http://gerrit.openvpn.net/c/openvpn/+/1573/comment/1c02cc50_f4e264bc?usp=email :
PS11, Line 112:  * @return a unit64_t containing the result of the hashing
"uint64_t"


File src/openvpn/siphash.c:

http://gerrit.openvpn.net/c/openvpn/+/1573/comment/d24e6b1f_a187f58e?usp=email :
PS11, Line 29: #include "config-msvc.h"
config-msvc.h again 😊


http://gerrit.openvpn.net/c/openvpn/+/1573/comment/93231b0b_647ee4f5?usp=email :
PS11, Line 46:     siphash_cryptolib_init(8);
Doesn't that need to check with `siphash_cryptolib_available`?
Should not hardcode "8". `sizeof(uint64_t)` maybe?



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1573?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I807f398903ac2047530800c29949793c6f4f0ec9
Gerrit-Change-Number: 1573
Gerrit-PatchSet: 11
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Fri, 24 Jul 2026 12:41:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel