[S] Change in openvpn[release/2.6]: management: resync timer on bytecount interval change

"plaisthos \(Code Review\) via Openvpn-devel" <[email protected]> Fri, 24 Jul 2026 16:57:17 +0000
Newsgroups gmane.network.openvpn.devel
Message-ID <81db64c840e263f6e8ce43ac37f369a993f7c389-EmailReviewComments-HTML@gerrit.openvpn.net>
Attention is currently required from: ralf_lici.

plaisthos has posted comments on this change by ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/1531?usp=email )

Change subject: management: resync timer on bytecount interval change
......................................................................


Patch Set 1:

(1 comment)

File src/openvpn/manage.c:

http://gerrit.openvpn.net/c/openvpn/+/1531/comment/89b44519_1aac559c?usp=email :
PS1, Line 494:     if (man->persist.callback.arg)
All the other uses of man->persist.callback.arg seem to just use that without check. Any reason that we need to check it here?



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1531?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: Ibea20c0f2c3df9f1f6509d662ab2b5fb4ce5e18d
Gerrit-Change-Number: 1531
Gerrit-PatchSet: 1
Gerrit-Owner: ralf_lici <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: ralf_lici <[email protected]>
Gerrit-Comment-Date: Fri, 24 Jul 2026 16:57:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel