[L] Change in openvpn[master]: oob: Add SERVER_PROBE parsing and the probe-reply decision

Attention is currently required from: stipa.

plaisthos has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1742?usp=email )

The change is no longer submittable: Code-Review is unsatisfied now.

Change subject: oob: Add SERVER_PROBE parsing and the probe-reply decision
......................................................................


Patch Set 8: Code-Review-2

(2 comments)

File src/openvpn/oob.h:

http://gerrit.openvpn.net/c/openvpn/+/1742/comment/901d01eb_60ff6821?usp=email :
PS8, Line 161:  * skipped, so the scan tolerates additional/future TLVs. @p payload is consumed
the scan?


File src/openvpn/oob.c:

http://gerrit.openvpn.net/c/openvpn/+/1742/comment/c2c75c09_6a659319?usp=email :
PS8, Line 226:     }
I think this is harmful if we drop them uncondionally. We should probably still accept them but maybe at a much lower rate than ones with correct time.

Otherwise the goal to eventually be able to replace the reset packet with these new packets will never work.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1742?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iafa9efc1c156974ad9f5752e9de810a8c2f68c30
Gerrit-Change-Number: 1742
Gerrit-PatchSet: 8
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: stipa <[email protected]>
Gerrit-Comment-Date: Sun, 26 Jul 2026 01:07:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel