[S] Change in openvpn[master]: oob: fall back quickly when a handshake shortcut is ignored

"plaisthos \(Code Review\) via Openvpn-devel" <[email protected]> Sun, 26 Jul 2026 02:08:53 +0000
Newsgroups gmane.network.openvpn.devel
Message-ID <aa26bea56293e2e3938ee4574e7c90b2f028b0ac-EmailReviewComments-HTML@gerrit.openvpn.net>
Attention is currently required from: stipa.

plaisthos has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1771?usp=email )

Change subject: oob: fall back quickly when a handshake shortcut is ignored
......................................................................


Patch Set 8:

(2 comments)

Patchset:

PS8: 
I am really confused what you are trying to do here. This seems more like fixing/masking an other bug/sympthon.


Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/1771/comment/e1447272_221f0d12?usp=email :
PS8, Line 10: drops the larger P_CONTROL_WKC_V1, or a version/bug mismatch), the client
This is wrong. The P_CONTROL_WKC_V1 would be identical whether you do the full three way handshake with RESET_V3 or with OOB_WKC_V1.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1771?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Icec4696ff263ab39ebab06e8d478395a5ddfaab9
Gerrit-Change-Number: 1771
Gerrit-PatchSet: 8
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: stipa <[email protected]>
Gerrit-Comment-Date: Sun, 26 Jul 2026 02:08:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel