[M] Change in openvpn[master]: oob: advertise a connect_lifetime handshake shortcut

Attention is currently required from: stipa.

plaisthos has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1768?usp=email )

Change subject: oob: advertise a connect_lifetime handshake shortcut
......................................................................


Patch Set 8:

(2 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/1768/comment/9c1f6d35_735d3c00?usp=email :
PS8, Line 11: handshake shortcut, letting a probing client reuse it as the server's
the seconds the reply?


File src/openvpn/oob.c:

http://gerrit.openvpn.net/c/openvpn/+/1768/comment/f338da62_9bdf6b98?usp=email :
PS8, Line 258: }
This scream that it needs to be refactored. This is a method that gets all parameters of a struct just to put them into a struct.

It does a little bit else but still.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1768?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib2b6c2246f9d9c0a505292ee8d879f714901ffae
Gerrit-Change-Number: 1768
Gerrit-PatchSet: 8
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: stipa <[email protected]>
Gerrit-Comment-Date: Sun, 26 Jul 2026 02:18:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel