[PATCH applied] Re: lladdr: Clean up code and BSD support

Gert Doering <[email protected]> Mon, 27 Jul 2026 12:04:22 +0200 (CEST)
Newsgroups gmane.network.openvpn.devel
Message-ID <[email protected]>
This is a mixture of "code cleanup", "platform support" (add this to
NetBSD) and "platform depreciation" (remove --lladdr support from 
OpenSolaris, because it does not work the way we use it, and probably
didn't ever...).  So "master" it is.

Tested some months ago, re-tested Linux, FreeBSD and NetBSD today.

Side note: Platforms nowadays actually tests for "is this a valid MAC"
(I guess looking at the multicast or the U/L bit) so 01:02:03:04:05:ff
is not :-) and will be reported properly.

Note 2: FreeBSD does actually show "built-in" and "configured" ether
addresses these days

$ ifconfig tap0
tap0: flags=1008843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST,LOWER_UP> metric 0 mtu 1500
        ether 58:9c:fc:03:03:03
        hwaddr 58:9c:fc:10:ff:ce

.. which is nice :-)

Note 3: *some* of the OSes base their TAP MAC on "something guid determined
at boot time", so OpenVPN gets the same MAC address every time - which helps
t_client tests (random MACs tend to cause delays due to ARP cache on the
other side).  Others randomize -> --lladdr can help with that...

Note 4: I can see Antonio jump up and down and ask for proper support
for net_addr_ll_set() on more platforms... ;-)

Your patch has been applied to the master branch.

commit 1e918232e20c4d09b4e0dcdbf91fbb5d5cb9cb23 (master)
Author: Frank Lichtenheld
Date:   Sat Jul 25 00:08:32 2026 +0200

     lladdr: Clean up code and BSD support

     Signed-off-by: Frank Lichtenheld <[email protected]>
     Acked-by: Gert Doering <[email protected]>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1675
     Message-Id: <[email protected]>
     URL: https://www.mail-archive.com/[email protected]/msg37863.html
     Signed-off-by: Gert Doering <[email protected]>


--
kind regards,

Gert Doering