[M] Change in openvpn[master]: multipeer: introduce asymmetric peer-id

Attention is currently required from: flichtenheld, its_Giaan, ordex.

plaisthos has posted comments on this change by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/1089?usp=email )

Change subject: multipeer: introduce asymmetric peer-id
......................................................................


Patch Set 28: Code-Review-1

(3 comments)

File src/openvpn/init.c:

http://gerrit.openvpn.net/c/openvpn/+/1089/comment/80ca065d_6d40bf39?usp=email :
PS28, Line 2210:     if (o->use_peer_id)
I think we should not use o->use_peer_id but rather check tls_multi->use_peer_id instead. 

We should also update o->use_peer_id to somethig like 

/** peer-id was pushed in the received options */
bool use_peer_id;

and then not try so hard keep o->use_peer_id in sync with the other methods of having peer_id negotiaed.


http://gerrit.openvpn.net/c/openvpn/+/1089/comment/9979a4d1_7c0adc14?usp=email :
PS28, Line 2686:         }
I think here you just want to use

            c->c2.tls_multi->rx_peer_id = c->options.peer_id;
            
since a server that wants to use assymetric peer id should not have pushed peer-id           as part of the pushed options. And being pushed a "peer-id xyz" mean that both direction should be set to that id.


http://gerrit.openvpn.net/c/openvpn/+/1089/comment/85aca552_9d31393f?usp=email :
PS28, Line 3485:             c->options.use_peer_id = true;
I think we can just remove this whole section. See my comment to tls_print_deferred_options_results.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1089?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0a13ee90b6706acf20eabcee3bab3f2dff639bf9
Gerrit-Change-Number: 1089
Gerrit-PatchSet: 28
Gerrit-Owner: its_Giaan <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: ordex <[email protected]>
Gerrit-Attention: its_Giaan <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Attention: ordex <[email protected]>
Gerrit-Comment-Date: Mon, 27 Jul 2026 16:01:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel