[M] Change in openvpn[master]: multipeer: introduce asymmetric peer-id

Attention is currently required from: cron2, flichtenheld, ordex, plaisthos.

its_Giaan has posted comments on this change by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/1089?usp=email )

Change subject: multipeer: introduce asymmetric peer-id
......................................................................


Patch Set 29:

(7 comments)

File src/openvpn/init.c:

http://gerrit.openvpn.net/c/openvpn/+/1089/comment/bdf8cbc3_8728920f?usp=email :
PS28, Line 2210:     if (o->use_peer_id)
> I think we should not use o->use_peer_id but rather check tls_multi->use_peer_id instead.  […]
Done


http://gerrit.openvpn.net/c/openvpn/+/1089/comment/ba692d43_01149e69?usp=email :
PS28, Line 2686:         }
> I think here you just want to use […]
Done


http://gerrit.openvpn.net/c/openvpn/+/1089/comment/2d9fdbb0_4880cd5f?usp=email :
PS28, Line 3483:         if (c->c2.tls_multi->rx_peer_id != MAX_PEER_ID)
> should that not check `tx_peer_id`?  We control "what we send" with `use_peer_id`, and that would be […]
Done


http://gerrit.openvpn.net/c/openvpn/+/1089/comment/da50ae29_57842b0a?usp=email :
PS28, Line 3485:             c->options.use_peer_id = true;
> I think we can just remove this whole section. See my comment to tls_print_deferred_options_results.
Done


File src/openvpn/ssl.c:

http://gerrit.openvpn.net/c/openvpn/+/1089/comment/233abad1_02fe649c?usp=email :
PS28, Line 2082:     }
> this is still ugly. […]
Done


http://gerrit.openvpn.net/c/openvpn/+/1089/comment/8cf8bc76_6d00696d?usp=email :
PS28, Line 2340:                 multi->tx_peer_id = multi->rx_peer_id;
> that comment is confusing. […]
Done


http://gerrit.openvpn.net/c/openvpn/+/1089/comment/a87d852e_76e6e317?usp=email :
PS28, Line 2352:         }
> Looks like a repeat of the previous code block... […]
Done



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1089?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0a13ee90b6706acf20eabcee3bab3f2dff639bf9
Gerrit-Change-Number: 1089
Gerrit-PatchSet: 29
Gerrit-Owner: its_Giaan <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: ordex <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Attention: ordex <[email protected]>
Gerrit-Comment-Date: Tue, 28 Jul 2026 07:47:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <[email protected]>
Comment-In-Reply-To: cron2 <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel