[M] Change in openvpn[master]: Rename variables that shadow other variables or functions

"plaisthos \(Code Review\) via Openvpn-devel" <[email protected]> Tue, 28 Jul 2026 12:41:59 +0000
Newsgroups gmane.network.openvpn.devel
Message-ID <f55fe3af8c3324d084fdbf44277727842e5fa87a-EmailReviewComments-HTML@gerrit.openvpn.net>
Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1618?usp=email )

Change subject: Rename variables that shadow other variables or functions
......................................................................


Patch Set 11:

(1 comment)

File src/openvpn/push.c:

http://gerrit.openvpn.net/c/openvpn/+/1618/comment/d2598ba1_0e5a6217?usp=email :
PS11, Line 1004:         openvpn_time(&local_now);
I think this is also a leftover of the multithread stuff. We should probably just remove openvpn_time and use update_now() here.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1618?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I528f5fd200d877841e473e5e05b7ac7915fa2e33
Gerrit-Change-Number: 1618
Gerrit-PatchSet: 11
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Tue, 28 Jul 2026 12:41:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel