[M] Change in openvpn[master]: oob: start the client handshake from the server probe

Attention is currently required from: plaisthos.

stipa has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1770?usp=email )

Change subject: oob: start the client handshake from the server probe
......................................................................


Patch Set 9:

(3 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/1770/comment/0c3a5f84_07b90a1a?usp=email :
PS8, Line 7: oob: client handshake shortcut via a server probe
> I don't think handshake shortcut is a good name here. Because that is not what this is really this. […]
agreed. Renamed, it is now "probe-started handshake". The message says that the handshake is not shortened - the probe and reply take place of the reset packets, not remove them. The saving is one RTT vs probing and then connecting.


File Changes.rst:

http://gerrit.openvpn.net/c/openvpn/+/1770/comment/938eb310_891c59a4?usp=email :
PS8, Line 15:     for it. This needs no extra configuration.
> there is no skipping of a round of three-way handshake. […]
Reworded.


File src/openvpn/oob_client.c:

http://gerrit.openvpn.net/c/openvpn/+/1770/comment/5ad93dd1_365c9d1e?usp=email :
PS8, Line 657:      * immediately before connecting (~0 s gap), so that check is a no-op today;
> You can probe two server and then both reply and then the you don't connect to both of them instantl […]
Right, the gap is not 0s for a later remote. The comment is confusing, let me make it shorter and clearer.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1770?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I454d5040cbad4d373ee4f90b8d683200d2a4c0e4
Gerrit-Change-Number: 1770
Gerrit-PatchSet: 9
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Tue, 28 Jul 2026 15:06:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel