[XS] Change in openvpn[master]: Correctly calculate packet id size when epoch packet format is in use

"plaisthos \(Code Review\) via Openvpn-devel" <[email protected]> Tue, 28 Jul 2026 23:00:03 +0000
Newsgroups gmane.network.openvpn.devel
Message-ID <a4b707de27f6fccba72aeeb832f97ac350423282-EmailReviewComments-HTML@gerrit.openvpn.net>
plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1829?usp=email )

Change subject: Correctly calculate packet id size when epoch packet format is in use
......................................................................


Patch Set 2:

(1 comment)

File src/openvpn/mtu.c:

http://gerrit.openvpn.net/c/openvpn/+/1829/comment/ca860431_f7fc1356?usp=email :
PS1, Line 59:         return sizeof(uint64_t);
> since we don't have explicit members to call sizeof() on, how about a little comment explaining the  […]
Done



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1829?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I5b862eabe032eb4d2229ff5b2f4f6af7406f6f4e
Gerrit-Change-Number: 1829
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: ordex <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Comment-Date: Tue, 28 Jul 2026 23:00:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ordex <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel