[S] Change in openvpn[master]: Add aws-lc siphash implementation
"flichtenheld \(Code Review\) via Openvpn-devel" <[email protected]> Thu, 30 Jul 2026 10:26:54 +0000
| Newsgroups | gmane.network.openvpn.devel |
|---|---|
| Message-ID | <48f20d3b831aff5a5e4aedc0b65aafdd6ed17761-EmailReviewComments-HTML@gerrit.openvpn.net> |
--===============1453988320679491769== Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="ZrnzTslKOhs="; charset=UTF-8 --ZrnzTslKOhs= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos=2E flichtenheld has posted= comments on this change by plaisthos=2E ( http://gerrit=2Eopenvpn=2Enet/c/= openvpn/+/1572?usp=3Demail ) Change subject: Add aws-lc siphash implementa= tion =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E Patch = Set 21: Code-Review-1 (2 comments) File src/openvpn/siphash=2Eh: http://= gerrit=2Eopenvpn=2Enet/c/openvpn/+/1572/comment/50f1bd52_999eb12f?usp=3Dema= il : PS21, Line 43: * @param in: pointer to input data (read-only) I don= 't think the ":" makes sense in doxygen http://gerrit=2Eopenvpn=2Enet/c/o= penvpn/+/1572/comment/a725d900_e6ee51cd?usp=3Demail : PS21, Line 57: re= turn 0; Can we please have a documentation for the return value=2E Also abo= ve in siphash_reference=2E -- To view, visit http://gerrit=2Eopenvpn=2E= net/c/openvpn/+/1572?usp=3Demail To unsubscribe, or for help writing mail f= ilters, visit http://gerrit=2Eopenvpn=2Enet/settings?usp=3Demail Gerrit-Me= ssageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Cha= nge-Id: I05e20f8c82494e4abf96fe1e3a73e1c7b9101af6 Gerrit-Change-Number: 157= 2 Gerrit-PatchSet: 21 Gerrit-Owner: plaisthos <arne-openvpn@rfc2549=2Eorg> = Gerrit-Reviewer: flichtenheld <frank@lichtenheld=2Ecom> Gerrit-CC: openvpn-= devel <openvpn-devel@lists=2Esourceforge=2Enet> Gerrit-Attention: plaisthos= <arne-openvpn@rfc2549=2Eorg> Gerrit-Comment-Date: Thu, 30 Jul 2026 10:26:5= 4 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes --ZrnzTslKOhs= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html><html><head><style></style></head><body><p> Attention is cur= rently required from: plaisthos=2E </p> <p>Patch set 21:<span style=3D"bord= er-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;backgrou= nd-color: #ffd4d4;">Code-Review -1</span></p><p><a href=3D"http://gerrit=2E= openvpn=2Enet/c/openvpn/+/1572?usp=3Demail">View Change</a></p><p>2 comment= s:</p><ul style=3D"list-style: none; padding: 0;"><li style=3D"margin: 0; p= adding: 0;"><p>File src/openvpn/siphash=2Eh:</p><ul style=3D"list-style: no= ne; padding: 0;"><li style=3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"= margin-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1= 572/comment/50f1bd52_999eb12f?usp=3Demail">Patch Set #21, Line 43:</a> <cod= e style=3D"font-family:monospace,monospace"> * @param in: pointer to inpu= t data (read-only)</code></p><p class=3D"blocks" style=3D"white-space: pre-= wrap; word-wrap: break-word;">I don't think the ":" makes sen= se in doxygen</p></li><li style=3D"margin: 0; padding: 0 0 0 16px;"><p styl= e=3D"margin-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvp= n/+/1572/comment/a725d900_e6ee51cd?usp=3Demail">Patch Set #21, Line 57:</a>= <code style=3D"font-family:monospace,monospace"> return 0;</code></p><p= class=3D"blocks" style=3D"white-space: pre-wrap; word-wrap: break-word;">C= an we please have a documentation for the return value=2E Also above in sip= hash_reference=2E</p></li></ul></li></ul><p>To view, visit <a href=3D"http:= //gerrit=2Eopenvpn=2Enet/c/openvpn/+/1572?usp=3Demail">change 1572</a>=2E T= o unsubscribe, or for help writing mail filters, visit <a href=3D"http://ge= rrit=2Eopenvpn=2Enet/settings?usp=3Demail">settings</a>=2E</p><div itemscop= e itemtype=3D"http://schema=2Eorg/EmailMessage"><div itemscope itemprop=3D"= action" itemtype=3D"http://schema=2Eorg/ViewAction"><link itemprop=3D"url" = href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1572?usp=3Demail"/><meta = itemprop=3D"name" content=3D"View Change"/></div></div> <div style=3D"disp= lay:none"> Gerrit-MessageType: comment </div> <div style=3D"display:none"> = Gerrit-Project: openvpn </div> <div style=3D"display:none"> Gerrit-Branch: = master </div> <div style=3D"display:none"> Gerrit-Change-Id: I05e20f8c82494= e4abf96fe1e3a73e1c7b9101af6 </div> <div style=3D"display:none"> Gerrit-Chan= ge-Number: 1572 </div> <div style=3D"display:none"> Gerrit-PatchSet: 21 </d= iv> <div style=3D"display:none"> Gerrit-Owner: plaisthos <arne-openvpn@r= fc2549=2Eorg> </div> <div style=3D"display:none"> Gerrit-Reviewer: flich= tenheld <frank@lichtenheld=2Ecom> </div> <div style=3D"display:none">= Gerrit-CC: openvpn-devel <openvpn-devel@lists=2Esourceforge=2Enet> <= /div> <div style=3D"display:none"> Gerrit-Attention: plaisthos <arne-ope= nvpn@rfc2549=2Eorg> </div> <div style=3D"display:none"> Gerrit-Comment-D= ate: Thu, 30 Jul 2026 10:26:54 +0000 </div> <div style=3D"display:none"> Ge= rrit-HasComments: Yes </div> <div style=3D"display:none"> Gerrit-Has-Labels= : Yes </div> </body></html> --ZrnzTslKOhs=-- --===============1453988320679491769== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============1453988320679491769== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel --===============1453988320679491769==--