[M] Change in openvpn[master]: Replace SHA256 with SIPHASH24 in hamc cookie approach
"plaisthos \(Code Review\) via Openvpn-devel" <[email protected]> Thu, 30 Jul 2026 12:02:14 +0000
| Newsgroups | gmane.network.openvpn.devel |
|---|---|
| Message-ID | <431cebb5bb67d2af8f2fcdf73639d30cdb4c33ac-EmailReviewComments-HTML@gerrit.openvpn.net> |
--===============8492158797137417338==
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="vbKY5hRj0Fk="; charset=UTF-8
--vbKY5hRj0Fk=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld=2E
plaisthos has posted=
comments on this change by plaisthos=2E ( http://gerrit=2Eopenvpn=2Enet/c/=
openvpn/+/1827?usp=3Demail )
Change subject: Replace SHA256 with SIPHASH24=
in hamc cookie approach
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E
Patch Set 1:
(3 comments)
Commit Message:
http://gerrit=
=2Eopenvpn=2Enet/c/openvpn/+/1827/comment/02ddaf25_c1974c19?usp=3Demail :
P=
S1, Line 7: Replace SHA256 with SIPHASH24 in hamc cookie approach
> "hmac"
=
Done
File src/openvpn/ssl_pkt=2Ec:
http://gerrit=2Eopenvpn=2Enet/c/openv=
pn/+/1827/comment/03e63c76_056f1882?usp=3Demail :
PS1, Line 458: /* ens=
ure out input is large enough */
> "our"
Done
http://gerrit=2Eopenvpn=2En=
et/c/openvpn/+/1827/comment/321fe484_41c054de?usp=3Demail :
PS1, Line 481: =
/* add session id of client */
> obsolete comment? or missing code?
No=
=2E Actually I accidentially removed hasing the client sid=2E Thanks for no=
ticing=2E
--
To view, visit http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1=
827?usp=3Demail
To unsubscribe, or for help writing mail filters, visit htt=
p://gerrit=2Eopenvpn=2Enet/settings?usp=3Demail
Gerrit-MessageType: commen=
t
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3b6bb178=
ffb2bb49981bc23eabf04fe8e06d6fc3
Gerrit-Change-Number: 1827
Gerrit-PatchSet=
: 1
Gerrit-Owner: plaisthos <arne-openvpn@rfc2549=2Eorg>
Gerrit-Reviewer: f=
lichtenheld <frank@lichtenheld=2Ecom>
Gerrit-CC: openvpn-devel <openvpn-dev=
el@lists=2Esourceforge=2Enet>
Gerrit-Attention: flichtenheld <frank@lichten=
held=2Ecom>
Gerrit-Comment-Date: Thu, 30 Jul 2026 12:02:14 +0000
Gerrit-Has=
Comments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <fran=
k@lichtenheld=2Ecom>
--vbKY5hRj0Fk=
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<!DOCTYPE html><html><head><style></style></head><body><p> Attention is cur=
rently required from: flichtenheld=2E </p>
<p><a href=3D"http://gerrit=2Eop=
envpn=2Enet/c/openvpn/+/1827?usp=3Demail">View Change</a></p><p>3 comments:=
</p><ul style=3D"list-style: none; padding: 0;"><li style=3D"margin: 0; pad=
ding: 0;"><p>Commit Message:</p><ul style=3D"list-style: none; padding: 0;"=
><li style=3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"margin-bottom: 4=
px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1827/comment/02dd=
af25_c1974c19?usp=3Demail">Patch Set #1, Line 7:</a> <code style=3D"font-fa=
mily:monospace,monospace">Replace SHA256 with SIPHASH24 in hamc cookie appr=
oach</code></p><p><blockquote style=3D"border-left: 1px solid #aaa; margin:=
10px 0; padding: 0 10px;">"hmac"</blockquote></p><p class=3D"blo=
cks" style=3D"white-space: pre-wrap; word-wrap: break-word;">Done</p></li><=
/ul></li><li style=3D"margin: 0; padding: 0;"><p>File src/openvpn/ssl_pkt=
=2Ec:</p><ul style=3D"list-style: none; padding: 0;"><li style=3D"margin: 0=
; padding: 0 0 0 16px;"><p style=3D"margin-bottom: 4px;"><a href=3D"http://=
gerrit=2Eopenvpn=2Enet/c/openvpn/+/1827/comment/03e63c76_056f1882?usp=3Dema=
il">Patch Set #1, Line 458:</a> <code style=3D"font-family:monospace,monosp=
ace"> /* ensure out input is large enough */</code></p><p><blockquote st=
yle=3D"border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">"=
;our"</blockquote></p><p class=3D"blocks" style=3D"white-space: pre-wr=
ap; word-wrap: break-word;">Done</p></li><li style=3D"margin: 0; padding: 0=
0 0 16px;"><p style=3D"margin-bottom: 4px;"><a href=3D"http://gerrit=2Eope=
nvpn=2Enet/c/openvpn/+/1827/comment/321fe484_41c054de?usp=3Demail">Patch Se=
t #1, Line 481:</a> <code style=3D"font-family:monospace,monospace"> /* =
add session id of client */</code></p><p><blockquote style=3D"border-left: =
1px solid #aaa; margin: 10px 0; padding: 0 10px;">obsolete comment? or miss=
ing code?</blockquote></p><p class=3D"blocks" style=3D"white-space: pre-wra=
p; word-wrap: break-word;">No=2E Actually I accidentially removed hasing th=
e client sid=2E Thanks for noticing=2E</p></li></ul></li></ul><p>To view, v=
isit <a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1827?usp=3Demail"=
>change 1827</a>=2E To unsubscribe, or for help writing mail filters, visit=
<a href=3D"http://gerrit=2Eopenvpn=2Enet/settings?usp=3Demail">settings</a=
>=2E</p><div itemscope itemtype=3D"http://schema=2Eorg/EmailMessage"><div i=
temscope itemprop=3D"action" itemtype=3D"http://schema=2Eorg/ViewAction"><l=
ink itemprop=3D"url" href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1827=
?usp=3Demail"/><meta itemprop=3D"name" content=3D"View Change"/></div></div=
>
<div style=3D"display:none"> Gerrit-MessageType: comment </div>
<div sty=
le=3D"display:none"> Gerrit-Project: openvpn </div>
<div style=3D"display:n=
one"> Gerrit-Branch: master </div>
<div style=3D"display:none"> Gerrit-Chan=
ge-Id: I3b6bb178ffb2bb49981bc23eabf04fe8e06d6fc3 </div>
<div style=3D"displ=
ay:none"> Gerrit-Change-Number: 1827 </div>
<div style=3D"display:none"> Ge=
rrit-PatchSet: 1 </div>
<div style=3D"display:none"> Gerrit-Owner: plaistho=
s <arne-openvpn@rfc2549=2Eorg> </div>
<div style=3D"display:none"> Ge=
rrit-Reviewer: flichtenheld <frank@lichtenheld=2Ecom> </div>
<div sty=
le=3D"display:none"> Gerrit-CC: openvpn-devel <openvpn-devel@lists=2Esou=
rceforge=2Enet> </div>
<div style=3D"display:none"> Gerrit-Attention: fl=
ichtenheld <frank@lichtenheld=2Ecom> </div>
<div style=3D"display:non=
e"> Gerrit-Comment-Date: Thu, 30 Jul 2026 12:02:14 +0000 </div>
<div style=
=3D"display:none"> Gerrit-HasComments: Yes </div>
<div style=3D"display:non=
e"> Gerrit-Has-Labels: No </div>
<div style=3D"display:none"> Comment-In-Re=
ply-To: flichtenheld <frank@lichtenheld=2Ecom> </div>
</body></html>
--vbKY5hRj0Fk=--
--===============8492158797137417338==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
--===============8492158797137417338==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
--===============8492158797137417338==--