[L] Change in openvpn[master]: Replace custom hash_func with siphash
"flichtenheld \(Code Review\) via Openvpn-devel" <[email protected]> Thu, 30 Jul 2026 18:49:07 +0000
| Newsgroups | gmane.network.openvpn.devel |
|---|---|
| Message-ID | <26357eba4a1fa53fcadce256374732bbe0524b98-EmailReviewComments-HTML@gerrit.openvpn.net> |
--===============2521955754480028302== Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="eDCKRoceHec="; charset=UTF-8 --eDCKRoceHec= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos=2E flichtenheld has posted= comments on this change by plaisthos=2E ( http://gerrit=2Eopenvpn=2Enet/c/= openvpn/+/1573?usp=3Demail ) Change subject: Replace custom hash_func with= siphash =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E Pat= ch Set 21: Code-Review-1 (2 comments) File src/openvpn/multi=2Ec: http:/= /gerrit=2Eopenvpn=2Enet/c/openvpn/+/1573/comment/98aca297_0d5d3b01?usp=3Dem= ail : PS21, Line 26: #include "siphash=2Eh" Unused? File src/openvpn/siph= ash=2Ec: http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1573/comment/70617dc5_9= 993e60f?usp=3Demail : PS21, Line 23: * 51 Franklin Street, Fifth Floor, B= oston, MA 02110-1301 USA=2E old header -- To view, visit http://gerrit= =2Eopenvpn=2Enet/c/openvpn/+/1573?usp=3Demail To unsubscribe, or for help w= riting mail filters, visit http://gerrit=2Eopenvpn=2Enet/settings?usp=3Dema= il Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: mast= er Gerrit-Change-Id: I807f398903ac2047530800c29949793c6f4f0ec9 Gerrit-Chang= e-Number: 1573 Gerrit-PatchSet: 21 Gerrit-Owner: plaisthos <arne-openvpn@rf= c2549=2Eorg> Gerrit-Reviewer: flichtenheld <frank@lichtenheld=2Ecom> Gerrit= -CC: openvpn-devel <openvpn-devel@lists=2Esourceforge=2Enet> Gerrit-Attenti= on: plaisthos <arne-openvpn@rfc2549=2Eorg> Gerrit-Comment-Date: Thu, 30 Jul= 2026 18:49:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes --eDCKRoceHec= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html><html><head><style></style></head><body><p> Attention is cur= rently required from: plaisthos=2E </p> <p>Patch set 21:<span style=3D"bord= er-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;backgrou= nd-color: #ffd4d4;">Code-Review -1</span></p><p><a href=3D"http://gerrit=2E= openvpn=2Enet/c/openvpn/+/1573?usp=3Demail">View Change</a></p><p>2 comment= s:</p><ul style=3D"list-style: none; padding: 0;"><li style=3D"margin: 0; p= adding: 0;"><p>File src/openvpn/multi=2Ec:</p><ul style=3D"list-style: none= ; padding: 0;"><li style=3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"ma= rgin-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/157= 3/comment/98aca297_0d5d3b01?usp=3Demail">Patch Set #21, Line 26:</a> <code = style=3D"font-family:monospace,monospace">#include "siphash=2Eh"<= /code></p><p class=3D"blocks" style=3D"white-space: pre-wrap; word-wrap: br= eak-word;">Unused?</p></li></ul></li><li style=3D"margin: 0; padding: 0;"><= p>File src/openvpn/siphash=2Ec:</p><ul style=3D"list-style: none; padding: = 0;"><li style=3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"margin-bottom= : 4px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1573/comment/7= 0617dc5_9993e60f?usp=3Demail">Patch Set #21, Line 23:</a> <code style=3D"fo= nt-family:monospace,monospace"> * 51 Franklin Street, Fifth Floor, Boston,= MA 02110-1301 USA=2E</code></p><p class=3D"blocks" style=3D"white-space: p= re-wrap; word-wrap: break-word;">old header</p></li></ul></li></ul><p>To vi= ew, visit <a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1573?usp=3De= mail">change 1573</a>=2E To unsubscribe, or for help writing mail filters, = visit <a href=3D"http://gerrit=2Eopenvpn=2Enet/settings?usp=3Demail">settin= gs</a>=2E</p><div itemscope itemtype=3D"http://schema=2Eorg/EmailMessage"><= div itemscope itemprop=3D"action" itemtype=3D"http://schema=2Eorg/ViewActio= n"><link itemprop=3D"url" href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+= /1573?usp=3Demail"/><meta itemprop=3D"name" content=3D"View Change"/></div>= </div> <div style=3D"display:none"> Gerrit-MessageType: comment </div> <di= v style=3D"display:none"> Gerrit-Project: openvpn </div> <div style=3D"disp= lay:none"> Gerrit-Branch: master </div> <div style=3D"display:none"> Gerrit= -Change-Id: I807f398903ac2047530800c29949793c6f4f0ec9 </div> <div style=3D"= display:none"> Gerrit-Change-Number: 1573 </div> <div style=3D"display:none= "> Gerrit-PatchSet: 21 </div> <div style=3D"display:none"> Gerrit-Owner: pl= aisthos <arne-openvpn@rfc2549=2Eorg> </div> <div style=3D"display:non= e"> Gerrit-Reviewer: flichtenheld <frank@lichtenheld=2Ecom> </div> <d= iv style=3D"display:none"> Gerrit-CC: openvpn-devel <openvpn-devel@lists= =2Esourceforge=2Enet> </div> <div style=3D"display:none"> Gerrit-Attenti= on: plaisthos <arne-openvpn@rfc2549=2Eorg> </div> <div style=3D"displ= ay:none"> Gerrit-Comment-Date: Thu, 30 Jul 2026 18:49:07 +0000 </div> <div = style=3D"display:none"> Gerrit-HasComments: Yes </div> <div style=3D"displa= y:none"> Gerrit-Has-Labels: Yes </div> </body></html> --eDCKRoceHec=-- --===============2521955754480028302== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============2521955754480028302== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel --===============2521955754480028302==--