[L] Change in openvpn[master]: Replace custom hash_func with siphash
"plaisthos \(Code Review\) via Openvpn-devel" <[email protected]> Mon, 3 Aug 2026 13:23:33 +0000
| Newsgroups | gmane.network.openvpn.devel |
|---|---|
| Message-ID | <36ca0a5b72b623ea70cb9572d635b6a4a3becc27-EmailReviewComments-HTML@gerrit.openvpn.net> |
--===============6565909632840485726== Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="rXD7cWSkk98="; charset=UTF-8 --rXD7cWSkk98= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld=2E plaisthos has posted= comments on this change by plaisthos=2E ( http://gerrit=2Eopenvpn=2Enet/c/= openvpn/+/1573?usp=3Demail ) Change subject: Replace custom hash_func with= siphash =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E Pat= ch Set 21: (2 comments) File src/openvpn/multi=2Ec: http://gerrit=2Eopen= vpn=2Enet/c/openvpn/+/1573/comment/be42e2ba_be812043?usp=3Demail : PS21, Li= ne 26: #include "siphash=2Eh" > Unused? Done File src/openvpn/siphash=2Ec= : http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1573/comment/06d9fa63_c211fa46= ?usp=3Demail : PS21, Line 23: * 51 Franklin Street, Fifth Floor, Boston, = MA 02110-1301 USA=2E > old header Done -- To view, visit http://gerrit= =2Eopenvpn=2Enet/c/openvpn/+/1573?usp=3Demail To unsubscribe, or for help w= riting mail filters, visit http://gerrit=2Eopenvpn=2Enet/settings?usp=3Dema= il Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: mast= er Gerrit-Change-Id: I807f398903ac2047530800c29949793c6f4f0ec9 Gerrit-Chang= e-Number: 1573 Gerrit-PatchSet: 21 Gerrit-Owner: plaisthos <arne-openvpn@rf= c2549=2Eorg> Gerrit-Reviewer: flichtenheld <frank@lichtenheld=2Ecom> Gerrit= -CC: openvpn-devel <openvpn-devel@lists=2Esourceforge=2Enet> Gerrit-Attenti= on: flichtenheld <frank@lichtenheld=2Ecom> Gerrit-Comment-Date: Mon, 03 Aug= 2026 13:23:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-= In-Reply-To: flichtenheld <frank@lichtenheld=2Ecom> --rXD7cWSkk98= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html><html><head><style></style></head><body><p> Attention is cur= rently required from: flichtenheld=2E </p> <p><a href=3D"http://gerrit=2Eop= envpn=2Enet/c/openvpn/+/1573?usp=3Demail">View Change</a></p><p>2 comments:= </p><ul style=3D"list-style: none; padding: 0;"><li style=3D"margin: 0; pad= ding: 0;"><p>File src/openvpn/multi=2Ec:</p><ul style=3D"list-style: none; = padding: 0;"><li style=3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"marg= in-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1573/= comment/be42e2ba_be812043?usp=3Demail">Patch Set #21, Line 26:</a> <code st= yle=3D"font-family:monospace,monospace">#include "siphash=2Eh"</c= ode></p><p><blockquote style=3D"border-left: 1px solid #aaa; margin: 10px 0= ; padding: 0 10px;">Unused?</blockquote></p><p class=3D"blocks" style=3D"wh= ite-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li sty= le=3D"margin: 0; padding: 0;"><p>File src/openvpn/siphash=2Ec:</p><ul style= =3D"list-style: none; padding: 0;"><li style=3D"margin: 0; padding: 0 0 0 1= 6px;"><p style=3D"margin-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn= =2Enet/c/openvpn/+/1573/comment/06d9fa63_c211fa46?usp=3Demail">Patch Set #2= 1, Line 23:</a> <code style=3D"font-family:monospace,monospace"> * 51 Fran= klin Street, Fifth Floor, Boston, MA 02110-1301 USA=2E</code></p><p><blockq= uote style=3D"border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;= ">old header</blockquote></p><p class=3D"blocks" style=3D"white-space: pre-= wrap; word-wrap: break-word;">Done</p></li></ul></li></ul><p>To view, visit= <a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1573?usp=3Demail">cha= nge 1573</a>=2E To unsubscribe, or for help writing mail filters, visit <a = href=3D"http://gerrit=2Eopenvpn=2Enet/settings?usp=3Demail">settings</a>=2E= </p><div itemscope itemtype=3D"http://schema=2Eorg/EmailMessage"><div items= cope itemprop=3D"action" itemtype=3D"http://schema=2Eorg/ViewAction"><link = itemprop=3D"url" href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1573?usp= =3Demail"/><meta itemprop=3D"name" content=3D"View Change"/></div></div> <= div style=3D"display:none"> Gerrit-MessageType: comment </div> <div style= =3D"display:none"> Gerrit-Project: openvpn </div> <div style=3D"display:non= e"> Gerrit-Branch: master </div> <div style=3D"display:none"> Gerrit-Change= -Id: I807f398903ac2047530800c29949793c6f4f0ec9 </div> <div style=3D"display= :none"> Gerrit-Change-Number: 1573 </div> <div style=3D"display:none"> Gerr= it-PatchSet: 21 </div> <div style=3D"display:none"> Gerrit-Owner: plaisthos= <arne-openvpn@rfc2549=2Eorg> </div> <div style=3D"display:none"> Ger= rit-Reviewer: flichtenheld <frank@lichtenheld=2Ecom> </div> <div styl= e=3D"display:none"> Gerrit-CC: openvpn-devel <openvpn-devel@lists=2Esour= ceforge=2Enet> </div> <div style=3D"display:none"> Gerrit-Attention: fli= chtenheld <frank@lichtenheld=2Ecom> </div> <div style=3D"display:none= "> Gerrit-Comment-Date: Mon, 03 Aug 2026 13:23:33 +0000 </div> <div style= =3D"display:none"> Gerrit-HasComments: Yes </div> <div style=3D"display:non= e"> Gerrit-Has-Labels: No </div> <div style=3D"display:none"> Comment-In-Re= ply-To: flichtenheld <frank@lichtenheld=2Ecom> </div> </body></html> --rXD7cWSkk98=-- --===============6565909632840485726== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============6565909632840485726== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel --===============6565909632840485726==--