[M] Change in openvpn[master]: Replace SHA256 with SIPHASH24 in HMAC cookie approach

Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1827?usp=email )

Change subject: Replace SHA256 with SIPHASH24 in HMAC cookie approach
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

File tests/unit_tests/openvpn/test_pkt.c:

http://gerrit.openvpn.net/c/openvpn/+/1827/comment/d54aaf7d_43adde42?usp=email :
PS4, Line 440:     rand_bytes(key, sizeof(key));
should also use siphash_key_init?


http://gerrit.openvpn.net/c/openvpn/+/1827/comment/4ffabac7_da54e325?usp=email :
PS4, Line 522:     rand_bytes(key, sizeof(key));
should also use siphash_key_init?



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1827?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3b6bb178ffb2bb49981bc23eabf04fe8e06d6fc3
Gerrit-Change-Number: 1827
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Wed, 05 Aug 2026 14:07:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel