[M] Change in openvpn[master]: dco: do not exit the process when installing a DCO key fails

Attention is currently required from: flichtenheld, plaisthos, ralf_lici.

ordex has posted comments on this change by ordex. ( http://gerrit.openvpn.net/c/openvpn/+/1835?usp=email )

Change subject: dco: do not exit the process when installing a DCO key fails
......................................................................


Patch Set 2:

(3 comments)

File src/openvpn/ssl.h:

http://gerrit.openvpn.net/c/openvpn/+/1835/comment/9325bea6_55bf70b8?usp=email :
PS2, Line 235: #define TLSMP_RESTART   4
> Since you explicitly link that to DCO restart in forward. […]
I just wanted to keep DCO out of this lower level bits where this constant is used. Ideally there might be future users for this constant, requiring the same treatment.


File src/openvpn/ssl.c:

http://gerrit.openvpn.net/c/openvpn/+/1835/comment/d424b9dc_f0774760?usp=email :
PS2, Line 1402:                 "notifying userspace. Restarting the session",
> Nipick: Missing punctuation at the end.
Acknowledged


File src/openvpn/ssl_common.h:

http://gerrit.openvpn.net/c/openvpn/+/1835/comment/488131ef_aa5a6fcb?usp=email :
PS2, Line 202: };
> Since that is only returned by the static method init_key_contexts inside ssl. […]
Oh!
Actually it is returned also by `tls_session_generate_data_channel_keys()`, that is not declared static. But after a deeper look I can see this function is called only in ssl.c....
So it could be made static as well and the enum could indeed live in ssl.c only.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1835?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I564edc6e0cc179c2b8b5ddef5e80838949fe9fcd
Gerrit-Change-Number: 1835
Gerrit-PatchSet: 2
Gerrit-Owner: ordex <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: ralf_lici <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Attention: ralf_lici <[email protected]>
Gerrit-Comment-Date: Wed, 05 Aug 2026 15:48:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <[email protected]>
Comment-In-Reply-To: flichtenheld <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel