[M] Change in openvpn[master]: Replace SHA256 with SIPHASH24 in HMAC cookie approach
"plaisthos \(Code Review\) via Openvpn-devel" <[email protected]>
| Newsgroups | gmane.network.openvpn.devel |
|---|---|
| Message-ID | <289467f4f18f4492947acbd3fa95503ad4569256-EmailReviewComments-HTML@gerrit.openvpn.net> |
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1827?usp=email ) Change subject: Replace SHA256 with SIPHASH24 in HMAC cookie approach ...................................................................... Patch Set 5: (1 comment) File tests/unit_tests/openvpn/test_pkt.c: http://gerrit.openvpn.net/c/openvpn/+/1827/comment/8024d63a_812aa102?usp=email : PS5, Line 522: rand_bytes(key, sizeof(key)); > You missed one. As apparently did I in my last review since I flagged two and you fixed two. […] damn. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1827?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3b6bb178ffb2bb49981bc23eabf04fe8e06d6fc3 Gerrit-Change-Number: 1827 Gerrit-PatchSet: 5 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Thu, 06 Aug 2026 16:58:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <[email protected]> _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel