[M] Change in openvpn[master]: Do not differentiate TLS server and client context initialisation

"plaisthos \(Code Review\) via Openvpn-devel" <[email protected]>
Newsgroups gmane.network.openvpn.devel
Message-ID <db24f3ca39f7add76da6b1c765e924ed30b17700-EmailReviewComments-HTML@gerrit.openvpn.net>
Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1728?usp=email )

Change subject: Do not differentiate TLS server and client context initialisation
......................................................................


Patch Set 5:

(4 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/1728/comment/3e003769_758190ff?usp=email :
PS4, Line 26: Our mbed TLS code basically does give the SSL context any personality
> "doesn't" ?
Done


http://gerrit.openvpn.net/c/openvpn/+/1728/comment/0997e078_7e579fd7?usp=email :
PS4, Line 28: code calls SSL_set_accept_state/SSL_set_connect_sate.
> "SSL_set_connect_state"
Done


http://gerrit.openvpn.net/c/openvpn/+/1728/comment/e65d33a7_d62837fb?usp=email :
PS4, Line 30: This also modifies the mbedTLS to use the decision to pick client
> "the mbedTLS backend" maybe?
Done


http://gerrit.openvpn.net/c/openvpn/+/1728/comment/bb73947d_7fe0c48e?usp=email :
PS4, Line 31: and server in that path as the OpenSSL code path.
> "in that path as the OpenSSL code path" -> "in key_state_ssl_init, same as OpenSSL"
Done



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1728?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iaf1f3475e4f27a920c028cd73b1a2497953583d0
Gerrit-Change-Number: 1728
Gerrit-PatchSet: 5
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Fri, 07 Aug 2026 13:49:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.