[M] Change in openvpn[master]: packet_id: Avoid conversion warnings

Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1407?usp=email )

Change subject: packet_id: Avoid conversion warnings
......................................................................


Patch Set 7:

(1 comment)

File src/openvpn/circ_list.h:

http://gerrit.openvpn.net/c/openvpn/+/1407/comment/e6d5f35a_344027b9?usp=email :
PS7, Line 51:                (obj)->x_cap)
> So the array index and the size should be the same type. Before we had int for both. […]
This is wrong. What I changed the value of is the size in bytes (x_sizeof), not the number of array elements (x_size and x_cap). x_sizeof will be always significantly larger than those.

As I have implied x_sizeof is not really used anyway. It is only printed once in packet_id_debug_print and otherwise ignored.

So I think this change is fine.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1407?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib0584e8728701cca10ac5675c9cb0e6f5eb901ac
Gerrit-Change-Number: 1407
Gerrit-PatchSet: 7
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Fri, 14 Aug 2026 11:11:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel