[XL] Change in openvpn[master]: options: Factor out options display code from options.c

Attention is currently required from: flichtenheld, plaisthos.

razvanc has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1772?usp=email )

Change subject: options: Factor out options display code from options.c
......................................................................


Patch Set 3:

(1 comment)

File src/openvpn/options_show.c:

http://gerrit.openvpn.net/c/openvpn/+/1772/comment/a5671ea6_e8cc4660?usp=email :
PS2, Line 25: #endif
> Have added the #include there. But not sure whether I should include options_show.h here. […]
It's not that we need anything from there, but my reasoning was that if we include the header here we will be warned for free, by the compiler, if the "public" function's signature drifts (in this case, `show_settings()`).



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1772?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I61762374c141662d596bbf88b64ca7f7472b5149
Gerrit-Change-Number: 1772
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: razvanc <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Mon, 17 Aug 2026 12:20:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]>
Comment-In-Reply-To: razvanc <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel