[L] Change in openvpn[master]: Reformat all shell-scripts with shfmt
"razvanc \(Code Review\) via Openvpn-devel" <[email protected]>
| Newsgroups | gmane.network.openvpn.devel |
|---|---|
| Message-ID | <4a018c027ba2ffaa6776cd8241e3d844889a7072-EmailReviewComments-HTML@gerrit.openvpn.net> |
Attention is currently required from: flichtenheld, plaisthos. razvanc has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1793?usp=email ) Change subject: Reformat all shell-scripts with shfmt ...................................................................... Patch Set 2: (1 comment) File dev-tools/gen-release-tarballs.sh: http://gerrit.openvpn.net/c/openvpn/+/1793/comment/5c92132b_f4bb5934?usp=email : PS2, Line 72: res="$(find . -maxdepth 1 -type f -name \"$wildcard\" | head -n1 | cut -d/ -f2-)" This doesn't have the same meaning as before. Within backticks slashes get stripped, but within `$()` they don't, so now `\"` will match a quote. You can test with `"openvpn-2.7.0.tar.gz"` (quotes included). -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1793?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I76cd38fc4f43c2b75ed4ca6b9a5c9ffdbf332a0f Gerrit-Change-Number: 1793 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: razvanc <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Tue, 18 Aug 2026 06:31:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel