[M] Change in openvpn[master]: packet_id: Avoid conversion warnings

Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1407?usp=email )

Change subject: packet_id: Avoid conversion warnings
......................................................................


Patch Set 8:

(2 comments)

File src/openvpn/circ_list.h:

http://gerrit.openvpn.net/c/openvpn/+/1407/comment/2e08c787_250f00f9?usp=email :
PS8, Line 63:         const size_t so = sizeof(list_type) + sizeof((dest)->x_list[0]) * (size); \
> Strictly speaking, if `size` is `int` this still breaks `-Wsign-conversion`, but we're using `-Wno-s […]
maybe then we could just have an explicit cast to size_t here?


File src/openvpn/circ_list.h:

http://gerrit.openvpn.net/c/openvpn/+/1407/comment/492532d5_ddbc4d93?usp=email :
PS7, Line 51:                (obj)->x_cap)
> This is wrong. […]
So I would rather than have x_sizeof removed if we really do not use it appart from a debug statement as I don't think mixing the types is good here.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1407?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib0584e8728701cca10ac5675c9cb0e6f5eb901ac
Gerrit-Change-Number: 1407
Gerrit-PatchSet: 8
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-Reviewer: razvanc <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Tue, 18 Aug 2026 14:51:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <[email protected]>
Comment-In-Reply-To: flichtenheld <[email protected]>
Comment-In-Reply-To: razvanc <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel