[M] Change in openvpn[master]: t_client.sh.in: Add support for expected test failures

Attention is currently required from: plaisthos, razvanc.

flichtenheld has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1755?usp=email )

Change subject: t_client.sh.in: Add support for expected test failures
......................................................................


Patch Set 5:

(2 comments)

File tests/t_client.sh.in:

http://gerrit.openvpn.net/c/openvpn/+/1755/comment/74400f0a_371645c7?usp=email :
PS5, Line 379:     $RUN_SUDO "${openvpn}" $openvpn_conf >>$LOGDIR/$SUF:openvpn.log &
> Should we make sure we don't also include these two synthetic lines in the grep input to prevent fal […]
I don't think that theoretical problem is worth complicating the code


http://gerrit.openvpn.net/c/openvpn/+/1755/comment/c34a1d82_afce4e95?usp=email :
PS5, Line 389:             grep "$expect_fail" $LOGDIR/$SUF:openvpn.log >/dev/null
> If we're not allowing for regular expressions, do we want this to be `grep -F`?
No, I think we do not want to limit this to -F



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1755?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6c51bcdda5666e0dab2adcdaff28408c9bfcb844
Gerrit-Change-Number: 1755
Gerrit-PatchSet: 5
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: razvanc <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: razvanc <[email protected]>
Gerrit-Comment-Date: Tue, 25 Aug 2026 15:44:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: razvanc <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel