[M] Change in openvpn[master]: Add unix-script functionality to the --management feature

Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1852?usp=email )

Change subject: Add unix-script functionality to the --management feature
......................................................................


Patch Set 8: Code-Review-1

(6 comments)

File doc/man-sections/management-options.rst:

http://gerrit.openvpn.net/c/openvpn/+/1852/comment/cf57342f_38e1e5b5?usp=email :
PS8, Line 33:   variables :code:`MANAGEMENT_SOCKET`, :code:`MANAGEMENT_PASSWORD`
The user variable is missing in the list


http://gerrit.openvpn.net/c/openvpn/+/1852/comment/cd8a5341_3be649ff?usp=email :
PS8, Line 142:   this option is not needed since a disconnect  will always generate a
Additional space after "disconnect"


http://gerrit.openvpn.net/c/openvpn/+/1852/comment/c4de05af_6ae04a8b?usp=email :
PS8, Line 143:   :code:`SIGTERM`.
The other documentation and the code says "SIGINT", not "SIGTERM"


File src/openvpn/init.c:

http://gerrit.openvpn.net/c/openvpn/+/1852/comment/eb9683fa_42aa1f3f?usp=email :
PS8, Line 4382:             c->options.management_addr = platform_create_temp_file(
Are there any "insecure use of temp file" concerns here? If we ignore that actual file and just use the name what can someone with write access to the tmp dir do? Just prevent the creation of the socket? Anything more nefarious?


File src/openvpn/manage.c:

http://gerrit.openvpn.net/c/openvpn/+/1852/comment/bbebc394_5de77151?usp=email :
PS8, Line 2662:             snprintf(ms->up.password, sizeof(ms->up.password),
Don't we also need to generate an username?


File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/1852/comment/a7e72c69_f167b742?usp=email :
PS8, Line 4304:         if (streq(p[2], "unix") || streq(p[2], "unix-script"))
Should we also update the usage information? It is rather long already though.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1852?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I307e64079f436aa782f7e24bfff665a545ad2fa0
Gerrit-Change-Number: 1852
Gerrit-PatchSet: 8
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Wed, 26 Aug 2026 12:26:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel