[XL] Change in openvpn[master]: Implement sending/receiving app custom control protocol
"plaisthos \(Code Review\) via Openvpn-devel" <[email protected]>
| Newsgroups | gmane.network.openvpn.devel |
|---|---|
| Message-ID | <1a068d8821be70c0930aba545e577e3e5741e127-EmailReviewComments-HTML@gerrit.openvpn.net> |
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1858?usp=email ) Change subject: Implement sending/receiving app custom control protocol ...................................................................... Patch Set 7: (6 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/1858/comment/a73ff0bf_a28fe2e8?usp=email : PS7, Line 8: > Should probably have a more informative commit message... I added a bit of detail. I am not sure if that is enough or if should add more. File doc/management-notes.txt: http://gerrit.openvpn.net/c/openvpn/+/1858/comment/2cfc1ab3_fa444e68?usp=email : PS7, Line 804: the common app custom protocols between the client and the sever and insruct > "instruct" Done http://gerrit.openvpn.net/c/openvpn/+/1858/comment/849c64a3_5071de33?usp=email : PS7, Line 814: This commands sends an app custom control message to a client, > "command" Done http://gerrit.openvpn.net/c/openvpn/+/1858/comment/4d3e874a_f86d254d?usp=email : PS7, Line 829: flags -- a colon seperated list of the encoding and the flag if > "separated" Done http://gerrit.openvpn.net/c/openvpn/+/1858/comment/eae2d13b_0570948e?usp=email : PS7, Line 839: This commands sends an app custom command to the peer, the format of the > It is not directly clear to me why we have two separate commands here? One if for P2MP and the other […] Yes. Will explicitly mention that. http://gerrit.openvpn.net/c/openvpn/+/1858/comment/aa0be400_85d94649?usp=email : PS7, Line 839: This commands sends an app custom command to the peer, the format of the > "command" Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1858?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4a6a6ef41e15896b8b79d795b2a6de86b8ae4c84 Gerrit-Change-Number: 1858 Gerrit-PatchSet: 7 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Wed, 26 Aug 2026 16:20:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <[email protected]> _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel